Search Linux Wireless

Re: [PATCH v2 13/22] cfg80211: handle Association Response from S1G STA

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 2020-08-31 at 13:55 -0700, Thomas Pedersen wrote:
> 
> +	/* Detect whether this was an S1G Association Response and adjust IE
> +	 * location accordingly.
> +	 */
> +	rcu_read_lock();
> +	ies = rcu_dereference(bss->ies);
> +	if (WARN_ON(!ies)) {
> +		rcu_read_unlock();
> +		return;
> +	}
> +	s1g = cfg80211_find_ie(WLAN_EID_S1G_CAPABILITIES, ies->data, ies->len);
> +	if (s1g) {
> +		cr.resp_ie = (u8 *)&mgmt->u.s1g_assoc_resp.variable;
> +		cr.resp_ie_len =
> +			len - offsetof(struct ieee80211_mgmt,
> +				       u.s1g_assoc_resp.variable);
> +	}
> +	rcu_read_unlock();

That ... is rather strange?

Why not check bss->channel->band?

johannes




[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Wireless Regulations]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux