On Mon, 2020-08-31 at 13:55 -0700, Thomas Pedersen wrote: > > + NL80211_ATTR_S1G_CAPABILITY, > + NL80211_ATTR_S1G_CAPABILITY_MASK, > /* add attributes here, update the policy in nl80211.c */ nit: keep a blank line? > [NL80211_ATTR_HE_6GHZ_CAPABILITY] = > NLA_POLICY_EXACT_LEN(sizeof(struct ieee80211_he_6ghz_capa)), > + [NL80211_ATTR_S1G_CAPABILITY] = { .len = NL80211_S1G_CAPABILITY_LEN }, > + [NL80211_ATTR_S1G_CAPABILITY_MASK] = { > + .len = NL80211_S1G_CAPABILITY_LEN }, Please use the NLA_POLICY_EXACT_LEN() as in the line above, unless this really was meant to be a *minimum* length, which I doubt? johannes