On Sat, 12 Sep 2020, Kalle Valo wrote: > Lee Jones <lee.jones@xxxxxxxxxx> wrote: > > > Kerneldoc expects attributes/parameters to be in '@*.: ' format and > > gets confused if the variable does not follow the type/attribute > > definitions. > > > > Fixes the following W=1 kernel build warning(s): > > > > drivers/net/wireless/ath/wil6210/debugfs.c:456: warning: Function parameter or member 'wil' not described in 'wil6210_debugfs_init_offset' > > drivers/net/wireless/ath/wil6210/debugfs.c:456: warning: Function parameter or member 'dbg' not described in 'wil6210_debugfs_init_offset' > > drivers/net/wireless/ath/wil6210/debugfs.c:456: warning: Function parameter or member 'base' not described in 'wil6210_debugfs_init_offset' > > drivers/net/wireless/ath/wil6210/debugfs.c:456: warning: Function parameter or member 'tbl' not described in 'wil6210_debugfs_init_offset' > > > > Cc: Kalle Valo <kvalo@xxxxxxxxxxxxxx> > > Cc: "David S. Miller" <davem@xxxxxxxxxxxxx> > > Cc: Jakub Kicinski <kuba@xxxxxxxxxx> > > Cc: linux-wireless@xxxxxxxxxxxxxxx > > Cc: wil6210@xxxxxxxxxxxxxxxx > > Cc: netdev@xxxxxxxxxxxxxxx > > Reviewed-by: Maya Erez <merez@xxxxxxxxxxxxxx> > > Signed-off-by: Lee Jones <lee.jones@xxxxxxxxxx> > > Aren't these also applied already? Please don't resend already applied > patches. Not at the time I rebased them. > 8 patches set to Rejected. > > 11766845 [06/29] wil6210: Fix a couple of formatting issues in 'wil6210_debugfs_init' > 11766747 [16/29] wil6210: wmi: Fix formatting and demote non-conforming function headers > 11766827 [17/29] wil6210: interrupt: Demote comment header which is clearly not kernel-doc > 11766825 [18/29] wil6210: txrx: Demote obvious abuse of kernel-doc > 11766823 [19/29] wil6210: txrx_edma: Demote comments which are clearly not kernel-doc > 11766821 [20/29] wil6210: pmc: Demote a few nonconformant kernel-doc function headers > 11766819 [21/29] wil6210: wil_platform: Demote kernel-doc header to standard comment block > 11766817 [22/29] wil6210: wmi: Correct misnamed function parameter 'ptr_' -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog
