On 2020-09-11 18:06, Johannes Berg wrote:
On Fri, 2020-09-11 at 09:29 +0000, Wen Gong wrote:
On 2020-05-29 03:34, Johannes Berg wrote:
> From: Johannes Berg <johannes.berg@xxxxxxxxx>
>
> Support connecting to HE 6 GHz APs and mesh networks on 6 GHz,
> where the HT/VHT information is missing but instead the HE 6 GHz
> band capability is present, and the 6 GHz Operation information
> field is used to encode the channel configuration instead of the
> HT/VHT operation elements.
>
> Also add some other bits needed to connect to 6 GHz networks.
>
> Link:
> https://lore.kernel.org/r/1589399105-25472-10-git-send-email-rmanohar@xxxxxxxxxxxxxx
> Co-developed-by: Rajkumar Manoharan <rmanohar@xxxxxxxxxxxxxx>
> Signed-off-by: Rajkumar Manoharan <rmanohar@xxxxxxxxxxxxxx>
> Signed-off-by: Johannes Berg <johannes.berg@xxxxxxxxx>
> ---
> net/mac80211/ieee80211_i.h | 3 ++
> net/mac80211/mesh.c | 1 +
> net/mac80211/mlme.c | 69 +++++++++++++++++-------
> net/mac80211/util.c | 106 +++++++++++++++++++++++++++++++++++++
> 4 files changed, 160 insertions(+), 19 deletions(-)
>
[...]
> @@ -4838,21 +4860,23 @@ static int ieee80211_prep_channel(struct
> ieee80211_sub_if_data *sdata,
> IEEE80211_STA_DISABLE_160MHZ);
>
> /* disable HT/VHT/HE if we don't support them */
> - if (!sband->ht_cap.ht_supported) {
> + if (!sband->ht_cap.ht_supported && !is_6ghz) {
> ifmgd->flags |= IEEE80211_STA_DISABLE_HT;
> ifmgd->flags |= IEEE80211_STA_DISABLE_VHT;
> ifmgd->flags |= IEEE80211_STA_DISABLE_HE;
> }
>
> - if (!sband->vht_cap.vht_supported)
> + if (!sband->vht_cap.vht_supported && !is_6ghz) {
> ifmgd->flags |= IEEE80211_STA_DISABLE_VHT;
> + ifmgd->flags |= IEEE80211_STA_DISABLE_HE;
> + }
when connec to NL80211_BAND_2GHZ, it does not support vht, then it
failed for HE and connected with HT mode.
I tesed with below change, it fix the issue, it connected with HE mode
for NL80211_BAND_2GHZ with an HE mode 11AX AP.
Hmm. Yeah, that seems reasonable. I wonder why/how we never saw this,
hm.
Can you send a real patch?
yes, patch sent:
https://lore.kernel.org/linux-wireless/010101747cb617f2-593c5410-1648-4a42-97a0-f3646a5a6dd1-000000@xxxxxxxxxxxxxxxxxxxxxxx/
johannes
