This series is three in a set of seven to add support for wcn3680 at 802.11ac data-rates. Both the BSS and STA config paths have redundant/duplicate code. Before adding more code to either it makes sense to reduce/reuse and functionally decompose as much as possible. While not strictly necessary to get the wcn3680/80211.ac functioning in this driver, it seems like a missed opportunity to leave the code as is. Lets reduce down before adding more. V5: - Fixes -W=1 warning caught in this set by kernel build robot I'm still declaring some functions standalone for the purposes of granularity and bisectability, a later patch makes relevant functions static. V4: - No functional change. Sending out full set again using --base=ath-202009090652 to aid kernel test robot - https://lore.kernel.org/linux-wireless/20200908182455.2870345-1-bryan.odonoghue@xxxxxxxxxx/T/#t V3: - No functional difference to V2 https://lore.kernel.org/linux-wireless/CAMZdPi___9yry0icuZVdnyiO7ZT0w=Xt8f8Pn7wkxRejxhXyYw@xxxxxxxxxxxxxx/T/#t - Adds Loic's Reviewed-by as indicated https://lore.kernel.org/linux-wireless/CAMZdPi___9yry0icuZVdnyiO7ZT0w=Xt8f8Pn7wkxRejxhXyYw@xxxxxxxxxxxxxx/T/#m2256137b97859c8eac26a2836f96db5e82475d3f V2: - Adds a memset to wcn36xx_smd_config_bss_v1() Since we are doing one less kzalloc() we need to make sure we clear out the bss config. V1: https://lore.kernel.org/linux-wireless/87eensldhi.fsf@xxxxxxxxxxxxxx/T/#t Bryan O'Donoghue (7): wcn36xx: Functionally decompose wcn36xx_smd_config_sta() wcn36xx: Move wcn36xx_smd_set_sta_params() inside wcn36xx_smd_config_bss() wcn36xx: Move BSS parameter setup to wcn36xx_smd_set_bss_params() wcn36xx: Update wcn36xx_smd_config_bss_v1() to operate internally wcn36xx: Add wcn36xx_smd_config_bss_v0 wcn36xx: Convert to using wcn36xx_smd_config_bss_v0() wcn36xx: Remove dead code in wcn36xx_smd_config_bss() drivers/net/wireless/ath/wcn36xx/smd.c | 422 ++++++++++++++----------- 1 file changed, 234 insertions(+), 188 deletions(-) base-commit: 160b351d75cb50a0dd2abf9b63e1891935aa9e4a prerequisite-patch-id: 9a4ac7faca179f6594c9b3a115ee69a2da540a69 prerequisite-patch-id: 183286f9c22d1aaa12f356651224e6b337ef1938 prerequisite-patch-id: af468d413daaf8d2aad195fcb43c6e66390d8468 prerequisite-patch-id: 08122a9557904ce5358f52dd08cc33270fa202c1 prerequisite-patch-id: 82e0b7c5b2e9fa80baca001cce12577d98e306a9 prerequisite-patch-id: 8ee7f5bd6cb5b7b7d713947b554ad93bb90d8230 prerequisite-patch-id: d05c2253e4523b05b2e43491aa13ceeef68fd2f0 prerequisite-patch-id: 8be29513d3efa64df15297bcf81ec3db55088ee1 prerequisite-patch-id: d267dcd834afad75a69bcd2adcccfdad6566a7ba -- 2.27.0
