Search Linux Wireless

Re: [PATCH v4 5/7] wcn36xx: Add wcn36xx_smd_config_bss_v0

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Bryan,

I love your patch! Perhaps something to improve:

[auto build test WARNING on 160b351d75cb50a0dd2abf9b63e1891935aa9e4a]

url:    https://github.com/0day-ci/linux/commits/Bryan-O-Donoghue/wcn36xx-Tidy-up-BSS-STA-config/20200910-011120
base:    160b351d75cb50a0dd2abf9b63e1891935aa9e4a
config: ia64-allmodconfig (attached as .config)
compiler: ia64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=ia64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All warnings (new ones prefixed by >>):

   drivers/net/wireless/ath/wcn36xx/smd.c:150:1: warning: no previous prototype for 'wcn36xx_smd_set_bss_vht_params' [-Wmissing-prototypes]
     150 | wcn36xx_smd_set_bss_vht_params(struct ieee80211_vif *vif,
         | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/net/wireless/ath/wcn36xx/smd.c:186:6: warning: no previous prototype for 'wcn36xx_smd_set_sta_vht_params' [-Wmissing-prototypes]
     186 | void wcn36xx_smd_set_sta_vht_params(struct wcn36xx *wcn,
         |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/net/wireless/ath/wcn36xx/smd.c:208:6: warning: no previous prototype for 'wcn36xx_smd_set_sta_ht_ldpc_params' [-Wmissing-prototypes]
     208 | void wcn36xx_smd_set_sta_ht_ldpc_params(struct ieee80211_sta *sta,
         |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/net/wireless/ath/wcn36xx/smd.c:233:6: warning: no previous prototype for 'wcn36xx_smd_set_sta_default_vht_params' [-Wmissing-prototypes]
     233 | void wcn36xx_smd_set_sta_default_vht_params(struct wcn36xx *wcn,
         |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/net/wireless/ath/wcn36xx/smd.c:249:6: warning: no previous prototype for 'wcn36xx_smd_set_sta_default_ht_ldpc_params' [-Wmissing-prototypes]
     249 | void wcn36xx_smd_set_sta_default_ht_ldpc_params(struct wcn36xx *wcn,
         |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/net/wireless/ath/wcn36xx/smd.c:1253:1: warning: no previous prototype for 'wcn36xx_smd_set_sta_params_v1' [-Wmissing-prototypes]
    1253 | wcn36xx_smd_set_sta_params_v1(struct wcn36xx *wcn,
         | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/net/wireless/ath/wcn36xx/smd.c:1387:6: warning: no previous prototype for 'wcn36xx_smd_set_bss_params' [-Wmissing-prototypes]
    1387 | void wcn36xx_smd_set_bss_params(struct wcn36xx *wcn,
         |      ^~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/net/wireless/ath/wcn36xx/smd.c: In function 'wcn36xx_smd_set_bss_params':
   drivers/net/wireless/ath/wcn36xx/smd.c:1395:40: warning: variable 'sta_params' set but not used [-Wunused-but-set-variable]
    1395 |  struct wcn36xx_hal_config_sta_params *sta_params;
         |                                        ^~~~~~~~~~
   drivers/net/wireless/ath/wcn36xx/smd.c: At top level:
>> drivers/net/wireless/ath/wcn36xx/smd.c:1587:5: warning: no previous prototype for 'wcn36xx_smd_config_bss_v0' [-Wmissing-prototypes]
    1587 | int wcn36xx_smd_config_bss_v0(struct wcn36xx *wcn, struct ieee80211_vif *vif,
         |     ^~~~~~~~~~~~~~~~~~~~~~~~~

# https://github.com/0day-ci/linux/commit/3c3f8bcaf7d541aab14db1b75513565dad07aa26
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Bryan-O-Donoghue/wcn36xx-Tidy-up-BSS-STA-config/20200910-011120
git checkout 3c3f8bcaf7d541aab14db1b75513565dad07aa26
vim +/wcn36xx_smd_config_bss_v0 +1587 drivers/net/wireless/ath/wcn36xx/smd.c

  1586	
> 1587	int wcn36xx_smd_config_bss_v0(struct wcn36xx *wcn, struct ieee80211_vif *vif,
  1588				      struct ieee80211_sta *sta, const u8 *bssid,
  1589				      bool update)
  1590	{
  1591		struct wcn36xx_hal_config_bss_req_msg *msg;
  1592		struct wcn36xx_hal_config_bss_params *bss;
  1593		struct wcn36xx_hal_config_sta_params *sta_params;
  1594		int ret;
  1595	
  1596		msg = kzalloc(sizeof(*msg), GFP_KERNEL);
  1597		if (!msg)
  1598			return -ENOMEM;
  1599	
  1600		INIT_HAL_MSG((*msg), WCN36XX_HAL_CONFIG_BSS_REQ);
  1601	
  1602		bss = &msg->bss_params;
  1603		sta_params = &bss->sta;
  1604	
  1605		wcn36xx_smd_set_bss_params(wcn, vif, sta, bssid, update, bss);
  1606		wcn36xx_smd_set_sta_params(wcn, vif, sta, sta_params);
  1607	
  1608		PREPARE_HAL_BUF(wcn->hal_buf, (*msg));
  1609	
  1610		wcn36xx_dbg(WCN36XX_DBG_HAL,
  1611			    "hal config bss bssid %pM self_mac_addr %pM bss_type %d oper_mode %d nw_type %d\n",
  1612			    bss->bssid, bss->self_mac_addr, bss->bss_type,
  1613			    bss->oper_mode, bss->nw_type);
  1614	
  1615		wcn36xx_dbg(WCN36XX_DBG_HAL,
  1616			    "- sta bssid %pM action %d sta_index %d bssid_index %d aid %d type %d mac %pM\n",
  1617			    sta_params->bssid, sta_params->action,
  1618			    sta_params->sta_index, sta_params->bssid_index,
  1619			    sta_params->aid, sta_params->type,
  1620			    sta_params->mac);
  1621	
  1622		ret = wcn36xx_smd_send_and_wait(wcn, msg->header.len);
  1623		kfree(msg);
  1624	
  1625		return ret;
  1626	}
  1627	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Wireless Regulations]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux