On Tue, 01 Sep 2020, Kalle Valo wrote:
> Lee Jones <lee.jones@xxxxxxxxxx> wrote:
>
> > Only include these tables in the 1 source file they are used.
> >
> > Fixes hundreds of W=1 warnings!
> >
> > Fixes the following W=1 kernel build warning(s):
> >
> > In file included from drivers/net/wireless/marvell/mwifiex/main.h:59,
> > from drivers/net/wireless/marvell/mwifiex/main.c:22:
> > drivers/net/wireless/marvell/mwifiex/sdio.h:705:41: warning: ‘mwifiex_sdio_sd8801’ defined but not used [-Wunused-const-variable=]
> > 705 | static const struct mwifiex_sdio_device mwifiex_sdio_sd8801 = {
> > | ^~~~~~~~~~~~~~~~~~~
> >
> > NB: There were 100's of these - snipped for brevity.
> >
> > Cc: Amitkumar Karwar <amitkarwar@xxxxxxxxx>
> > Cc: Ganapathi Bhat <ganapathi.bhat@xxxxxxx>
> > Cc: Xinming Hu <huxinming820@xxxxxxxxx>
> > Cc: Kalle Valo <kvalo@xxxxxxxxxxxxxx>
> > Cc: "David S. Miller" <davem@xxxxxxxxxxxxx>
> > Cc: Jakub Kicinski <kuba@xxxxxxxxxx>
> > Cc: linux-wireless@xxxxxxxxxxxxxxx
> > Cc: netdev@xxxxxxxxxxxxxxx
> > Signed-off-by: Lee Jones <lee.jones@xxxxxxxxxx>
>
> I don't think static const variables should be in a .h file. Wouldn't
> sdio.c be the right place for these? At least from a quick look I got
> that impression.
That's a bone of contention. I personally do not like to see C-files
overwhelmed by a sea of structs/tables and tend to ferry them off into
*-tables.h header files instead.
As the gate-keeper, what you say goes. So if you insist we move these
450 lines of tables into the source file which references them, I will
of course do as you ask.
> Patch set to Changes Requested.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
