On Tue, 2020-09-01 at 12:36 -0500, Gustavo A. R. Silva wrote: > Replace the existing /* fall through */ comments and its variants with > the new pseudo-keyword macro fallthrough[1]. Also, remove unnecessary > fall-through markings when it is the case. [] > diff --git a/drivers/net/wireless/mediatek/mt7601u/dma.c b/drivers/net/wireless/mediatek/mt7601u/dma.c [] > @@ -196,7 +196,7 @@ static void mt7601u_complete_rx(struct urb *urb) > default: > dev_err_ratelimited(dev->dev, "rx urb failed: %d\n", > urb->status); > - /* fall through */ > + fallthrough; fallthrough to break is odd. break would probably be better. > case 0: > break; > } > @@ -241,7 +241,7 @@ static void mt7601u_complete_tx(struct urb *urb) > default: > dev_err_ratelimited(dev->dev, "tx urb failed: %d\n", > urb->status); > - /* fall through */ > + fallthrough; here too... > case 0: > break; > } >
