On 2020-09-08 00:22, Kalle Valo wrote:
Wen Gong <wgong@xxxxxxxxxxxxxx> writes:
[...]
Just like with the recent firmware restart patch, isn't
ar->napi_enabled
racy? Wouldn't test_and_set_bit() and test_and_clear_bit() be safer?
Or are we holding a lock? But then that should be documented with
lockdep_assert_held().
yes, ath10k_hif_start is only called from ath10k_core_start, it has
"lockdep_assert_held(&ar->conf_mutex)",
and ath10k_hif_stop is only called from ath10k_core_stop, it also has
"lockdep_assert_held(&ar->conf_mutex)".
then it will not 2 thread both enter ath10k_hif_start/ath10k_hif_stop
meanwhile.
