Wright Feng <wright.feng@xxxxxxxxxxx> writes:
> Hostap has a parameter "ap_isolate" which is used to prevent low-level
> bridging of frames between associated stations in the BSS.
> Regarding driver side, we add cfg80211 ops method change_bss to support
> setting AP isolation if firmware has ap_isolate feature.
>
> Signed-off-by: Wright Feng <wright.feng@xxxxxxxxxxx>
> Signed-off-by: Chi-hsien Lin <chi-hsien.lin@xxxxxxxxxxx>
> ---
> .../broadcom/brcm80211/brcmfmac/cfg80211.c | 23 +++++++++++++++++++
> .../broadcom/brcm80211/brcmfmac/feature.c | 1 +
> .../broadcom/brcm80211/brcmfmac/feature.h | 3 ++-
> 3 files changed, 26 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
> index 5d99771c3f64..7ef93cd66b2c 100644
> --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
> +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
> @@ -5425,6 +5425,26 @@ static int brcmf_cfg80211_del_pmk(struct wiphy *wiphy, struct net_device *dev,
> return brcmf_set_pmk(ifp, NULL, 0);
> }
>
> +static int
> +brcmf_cfg80211_change_bss(struct wiphy *wiphy, struct net_device *dev,
> + struct bss_parameters *params)
> +{
> + struct brcmf_if *ifp;
> + int ret = 0;
> + u32 ap_isolate;
> +
> + brcmf_dbg(TRACE, "Enter\n");
> + ifp = netdev_priv(dev);
> + if (params->ap_isolate >= 0) {
> + ap_isolate = (u32)params->ap_isolate;
Is the cast to u32 really necessary? Please avoid casts as much as
possible.
--
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
