Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx> writes: > On 02/09/2020 09:59, Kalle Valo wrote: >> Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx> wrote: >> >>> In order to pass VHT parameters to wcn3680 we need to use a super-set of >>> the V1 data-structures with additional VHT parameters tacked on. >>> >>> This patch adds the additional fields to the STA and BSS parameter >>> structures with some utility macros to make calculation of the structure >>> size easier. >>> >>> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx> >> >> New warnings: >> >> drivers/net/wireless/ath/wcn36xx/smd.c:1257:1: warning: >> 'wcn36xx_smd_set_sta_params_v1' defined but not used >> [-Wunused-function] >> 1257 | wcn36xx_smd_set_sta_params_v1(struct wcn36xx *wcn, >> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >> drivers/net/wireless/ath/wcn36xx/smd.c:150:1: warning: >> 'wcn36xx_smd_set_bss_vht_params' defined but not used >> [-Wunused-function] >> 150 | wcn36xx_smd_set_bss_vht_params(struct ieee80211_vif *vif, >> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > I'm declaring a series of functions in patches for later use, in > patches 03-10. > > Do you want those squashed into the patch/patches where they are first > used ? Yeah, squashing them is better. Every patch should compile on it's own and be warning free. Kbuild bot will even check that and report if there are warnings in-between patches. -- https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
