Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx> wrote: > In order to pass VHT parameters to wcn3680 we need to use a super-set of > the V1 data-structures with additional VHT parameters tacked on. > > This patch adds the additional fields to the STA and BSS parameter > structures with some utility macros to make calculation of the structure > size easier. > > Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx> New warnings: drivers/net/wireless/ath/wcn36xx/smd.c:1257:1: warning: 'wcn36xx_smd_set_sta_params_v1' defined but not used [-Wunused-function] 1257 | wcn36xx_smd_set_sta_params_v1(struct wcn36xx *wcn, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/net/wireless/ath/wcn36xx/smd.c:150:1: warning: 'wcn36xx_smd_set_bss_vht_params' defined but not used [-Wunused-function] 150 | wcn36xx_smd_set_bss_vht_params(struct ieee80211_vif *vif, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 12 patches set to Changes Requested. 11743937 [v2,01/12] wcn36xx: Add VHT fields to parameter data structures 11743997 [v2,02/12] wcn36xx: Use V1 data structure to store supported rates 11743939 [v2,03/12] wcn36xx: Add wcn36xx_set_default_rates_v1 11743977 [v2,04/12] wcn36xx: Add VHT rates to wcn36xx_update_allowed_rates() 11743963 [v2,05/12] wcn36xx: Add wcn36xx_smd_set_sta_default_vht_params() 11743943 [v2,06/12] wcn36xx: Add wcn36xx_smd_set_sta_default_ht_ldpc_params() 11743945 [v2,07/12] wcn36xx: Add wcn36xx_smd_set_sta_vht_params() 11743951 [v2,08/12] wcn36xx: Add wcn36xx_smd_set_sta_ht_ldpc_params() 11743949 [v2,09/12] wcn36xx: Add wcn36xx_smd_set_bss_vht_params() 11743947 [v2,10/12] wcn36xx: Add wrapper function wcn36xx_smd_set_sta_params_v1() 11743961 [v2,11/12] wcn36xx: Define INIT_HAL_MSG_V1() 11743953 [v2,12/12] wcn36xx: Convert to VHT parameter structure on wcn3680 -- https://patchwork.kernel.org/patch/11743937/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches