Search Linux Wireless

[wireless-drivers-next:pending 90/109] drivers/net/wireless/broadcom/brcm80211/brcmsmac/ampdu.c:1027:20: warning: variable 'scb_ampdu' set but not used

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



tree:   https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git pending
head:   391ddee90739538e99cb73bd26d7a90452d37f30
commit: d7f95d9204ca1a73183fde8c5a017f2060763d05 [90/109] brcmsmac: ampdu: Remove a bunch of unused variables
config: i386-randconfig-r015-20200901 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce (this is a W=1 build):
        git checkout d7f95d9204ca1a73183fde8c5a017f2060763d05
        # save the attached .config to linux build tree
        make W=1 ARCH=i386 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All warnings (new ones prefixed by >>):

   In file included from drivers/net/wireless/broadcom/brcm80211/brcmsmac/rate.h:21,
                    from drivers/net/wireless/broadcom/brcm80211/brcmsmac/ampdu.c:18:
   drivers/net/wireless/broadcom/brcm80211/brcmsmac/d11.h:786:1: warning: alignment 1 of 'struct d11txh' is less than 2 [-Wpacked-not-aligned]
     786 | } __packed;
         | ^
   drivers/net/wireless/broadcom/brcm80211/brcmsmac/ampdu.c: In function 'brcms_c_ampdu_dotxstatus_complete':
   drivers/net/wireless/broadcom/brcm80211/brcmsmac/ampdu.c:850:7: warning: variable 'update_rate' set but not used [-Wunused-but-set-variable]
     850 |  bool update_rate = true, retry = true;
         |       ^~~~~~~~~~~
   drivers/net/wireless/broadcom/brcm80211/brcmsmac/ampdu.c: In function 'brcms_c_ampdu_dotxstatus':
>> drivers/net/wireless/broadcom/brcm80211/brcmsmac/ampdu.c:1027:20: warning: variable 'scb_ampdu' set but not used [-Wunused-but-set-variable]
    1027 |  struct scb_ampdu *scb_ampdu;
         |                    ^~~~~~~~~

# https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git/commit/?id=d7f95d9204ca1a73183fde8c5a017f2060763d05
git remote add wireless-drivers-next https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git
git fetch --no-tags wireless-drivers-next pending
git checkout d7f95d9204ca1a73183fde8c5a017f2060763d05
vim +/scb_ampdu +1027 drivers/net/wireless/broadcom/brcm80211/brcmsmac/ampdu.c

5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/ampdu.c Arend van Spriel 2011-10-05  1022  
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/ampdu.c Arend van Spriel 2011-10-05  1023  void
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/ampdu.c Arend van Spriel 2011-10-05  1024  brcms_c_ampdu_dotxstatus(struct ampdu_info *ampdu, struct scb *scb,
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/ampdu.c Arend van Spriel 2011-10-05  1025  		     struct sk_buff *p, struct tx_status *txs)
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/ampdu.c Arend van Spriel 2011-10-05  1026  {
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/ampdu.c Arend van Spriel 2011-10-05 @1027  	struct scb_ampdu *scb_ampdu;
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/ampdu.c Arend van Spriel 2011-10-05  1028  	struct brcms_c_info *wlc = ampdu->wlc;
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/ampdu.c Arend van Spriel 2011-10-05  1029  	u32 s1 = 0, s2 = 0;
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/ampdu.c Arend van Spriel 2011-10-05  1030  
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/ampdu.c Arend van Spriel 2011-10-05  1031  	/* BMAC_NOTE: For the split driver, second level txstatus comes later
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/ampdu.c Arend van Spriel 2011-10-05  1032  	 * So if the ACK was received then wait for the second level else just
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/ampdu.c Arend van Spriel 2011-10-05  1033  	 * call the first one
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/ampdu.c Arend van Spriel 2011-10-05  1034  	 */
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/ampdu.c Arend van Spriel 2011-10-05  1035  	if (txs->status & TX_STATUS_ACK_RCV) {
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/ampdu.c Arend van Spriel 2011-10-05  1036  		u8 status_delay = 0;
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/ampdu.c Arend van Spriel 2011-10-05  1037  
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/ampdu.c Arend van Spriel 2011-10-05  1038  		/* wait till the next 8 bytes of txstatus is available */
16d2812e9eaaa4 drivers/net/wireless/brcm80211/brcmsmac/ampdu.c Arend van Spriel 2011-12-08  1039  		s1 = bcma_read32(wlc->hw->d11core, D11REGOFFS(frmtxstatus));
16d2812e9eaaa4 drivers/net/wireless/brcm80211/brcmsmac/ampdu.c Arend van Spriel 2011-12-08  1040  		while ((s1 & TXS_V) == 0) {
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/ampdu.c Arend van Spriel 2011-10-05  1041  			udelay(1);
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/ampdu.c Arend van Spriel 2011-10-05  1042  			status_delay++;
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/ampdu.c Arend van Spriel 2011-10-05  1043  			if (status_delay > 10)
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/ampdu.c Arend van Spriel 2011-10-05  1044  				return; /* error condition */
16d2812e9eaaa4 drivers/net/wireless/brcm80211/brcmsmac/ampdu.c Arend van Spriel 2011-12-08  1045  			s1 = bcma_read32(wlc->hw->d11core,
16d2812e9eaaa4 drivers/net/wireless/brcm80211/brcmsmac/ampdu.c Arend van Spriel 2011-12-08  1046  					 D11REGOFFS(frmtxstatus));
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/ampdu.c Arend van Spriel 2011-10-05  1047  		}
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/ampdu.c Arend van Spriel 2011-10-05  1048  
16d2812e9eaaa4 drivers/net/wireless/brcm80211/brcmsmac/ampdu.c Arend van Spriel 2011-12-08  1049  		s2 = bcma_read32(wlc->hw->d11core, D11REGOFFS(frmtxstatus2));
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/ampdu.c Arend van Spriel 2011-10-05  1050  	}
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/ampdu.c Arend van Spriel 2011-10-05  1051  
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/ampdu.c Arend van Spriel 2011-10-05  1052  	if (scb) {
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/ampdu.c Arend van Spriel 2011-10-05  1053  		scb_ampdu = &scb->scb_ampdu;
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/ampdu.c Arend van Spriel 2011-10-05  1054  		brcms_c_ampdu_dotxstatus_complete(ampdu, scb, p, txs, s1, s2);
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/ampdu.c Arend van Spriel 2011-10-05  1055  	} else {
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/ampdu.c Arend van Spriel 2011-10-05  1056  		/* loop through all pkts and free */
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/ampdu.c Arend van Spriel 2011-10-05  1057  		u8 queue = txs->frameid & TXFID_QUEUE_MASK;
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/ampdu.c Arend van Spriel 2011-10-05  1058  		struct d11txh *txh;
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/ampdu.c Arend van Spriel 2011-10-05  1059  		u16 mcl;
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/ampdu.c Arend van Spriel 2011-10-05  1060  		while (p) {
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/ampdu.c Arend van Spriel 2011-10-05  1061  			txh = (struct d11txh *) p->data;
cdf4352f5c59ee drivers/net/wireless/brcm80211/brcmsmac/ampdu.c Seth Forshee     2012-11-15  1062  			trace_brcms_txdesc(&wlc->hw->d11core->dev, txh,
cdf4352f5c59ee drivers/net/wireless/brcm80211/brcmsmac/ampdu.c Seth Forshee     2012-11-15  1063  					   sizeof(*txh));
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/ampdu.c Arend van Spriel 2011-10-05  1064  			mcl = le16_to_cpu(txh->MacTxControlLow);
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/ampdu.c Arend van Spriel 2011-10-05  1065  			brcmu_pkt_buf_free_skb(p);
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/ampdu.c Arend van Spriel 2011-10-05  1066  			/* break out if last packet of ampdu */
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/ampdu.c Arend van Spriel 2011-10-05  1067  			if (((mcl & TXC_AMPDU_MASK) >> TXC_AMPDU_SHIFT) ==
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/ampdu.c Arend van Spriel 2011-10-05  1068  			    TXC_AMPDU_LAST)
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/ampdu.c Arend van Spriel 2011-10-05  1069  				break;
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/ampdu.c Arend van Spriel 2011-10-05  1070  			p = dma_getnexttxp(wlc->hw->di[queue],
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/ampdu.c Arend van Spriel 2011-10-05  1071  					   DMA_RANGE_TRANSMITTED);
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/ampdu.c Arend van Spriel 2011-10-05  1072  		}
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/ampdu.c Arend van Spriel 2011-10-05  1073  	}
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/ampdu.c Arend van Spriel 2011-10-05  1074  }
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/ampdu.c Arend van Spriel 2011-10-05  1075  

:::::: The code at line 1027 was first introduced by commit
:::::: 5b435de0d786869c95d1962121af0d7df2542009 net: wireless: add brcm80211 drivers

:::::: TO: Arend van Spriel <arend@xxxxxxxxxxxx>
:::::: CC: John W. Linville <linville@xxxxxxxxxxxxx>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Wireless Regulations]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux