On Mon, Sep 08, 2008 at 10:52:20AM +0530, Marcel Holtmann wrote: > Hi Vasanthakumar, > > > > > CONFIG_ATH9K_RFKILL needs to be set > > > > to enable this support. > > > > > > why do we have to introduce yet another config option for this? What is > > > the advantage of disabling RFKILL support? I really don't see it and all > > > these extra config options are rather confusing than useful. > > Normally home users may not hit a situation where they have to > > disable the radio, so they can compile out the rf kill support > > and essentially disable the periodic run of the work queue > > (rfkill_poll ,runs for every 2 secs).If this does not make > > any sense, I will remove this config option. > > I don't know about the actual implementation, but if you use a polling > mechanism then it is wrong. Can't you make this interrupt driven. There is some issue in GPIO intrrupt genenration, we can't make it interrupt driven. > > The desktop use case needs RFKILL support, because that will be used for > switching off the radio. Just think about the flight mode case. So the > only case where disabling RFKILL support makes sense would be an > embedded system with specific constraints. However even in the embedded > case, I don't see that usefulness. > Yeah, I understand. > Regards > > Marcel > Regards Vasanth > -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html