Alex Dewar <alex.dewar90@xxxxxxxxx> wrote: > In ath11k_qmi_prepare_bdf_download(), ath11k_core_firmware_request() is > called, but the returned pointer is not checked for errors. Rather the > variable ret (which will always be zero) is checked by mistake. Fix > this and replace the various gotos with simple returns for clarity. > > While we are at it, move the call to memset, as variable bd is not used > on all code paths. > > Fixes: 7b57b2ddec21 ("ath11k: create a common function to request all firmware files") > Signed-off-by: Alex Dewar <alex.dewar90@xxxxxxxxx> > Signed-off-by: Kalle Valo <kvalo@xxxxxxxxxxxxxx> Patch applied to ath-next branch of ath.git, thanks. 342b6194a75b ath11k: return error if firmware request fails -- https://patchwork.kernel.org/patch/11735787/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches