On Tue, 2020-08-04 at 09:02 +0530, Veerendranath Jakkam wrote:
> Add a new feature flag that drivers in which FT handshake is offloaded,
"that drivers (in which ...)" what? Can set? Are expected to use?
> to advertise support for interoperability with legacy clients which
> doesn't
don't? or what does "doesn't" refer to?
> support using RSNXE IE for MIC calculation in FT handshake. The
> userspace can choose to enable/disable FT protocols that require RSNXE IE
> to be used based on this flag advertised by drivers.
I can't say I really understand this.
> Signed-off-by: Veerendranath Jakkam <vjakkam@xxxxxxxxxxxxxx>
>
> diff --git a/include/uapi/linux/nl80211.h b/include/uapi/linux/nl80211.h
> index 631f3a99..83e8079 100644
> --- a/include/uapi/linux/nl80211.h
> +++ b/include/uapi/linux/nl80211.h
> @@ -5820,6 +5820,9 @@ enum nl80211_feature_flags {
> * @NL80211_EXT_FEATURE_4WAY_HANDSHAKE_AP_PSK: Device wants to do 4-way
> * handshake with PSK in AP mode (PSK is passed as part of the start AP
> * command).
> + * @NL80211_EXT_FEATURE_FT_RSNXE: Driver supports RSNXE element in FT handshake
> + * and interoperable with legacy clients that doesn't support using RSNXE
> + * IE for MIC computation in FT handshake.
Nor this. Please rewrite the commit message and comment to be more
explanatory (and grammatically correct).
johannes
