John Crispin <john@xxxxxxxxxxx> writes: > From: Miles Hu <milehu@xxxxxxxxxxxxxx> > > This patch adds code to parse HE fields inside ppdu TLVs. Then it adds the > populates the additional info into the ratiotap header. Also fix missing > QoS tag in native wifi mode. Finally rssi and tsf are also added. > > Signed-off-by: Miles Hu <milehu@xxxxxxxxxxxxxx> > Signed-off-by: John Crispin <john@xxxxxxxxxxx> On what hardware and firmware was this tested? I did quite a few cosmetic changes in the pending branch. > + value = FIELD_GET(HAL_RX_HE_SIG_A_SU_INFO_INFO0_BSS_COLOR, info0); > + ppdu_info->he_data3 = value; > + value = FIELD_GET(HAL_RX_HE_SIG_A_SU_INFO_INFO0_BEAM_CHANGE, info0); > + value = value << HE_BEAM_CHANGE_SHIFT; [...] > +#define HAL_RX_HE_SIG_A_SU_INFO_INFO0_BEAM_CHANGE BIT(1) > +#define HE_BEAM_CHANGE_SHIFT 6 There's a lot of these shifts which I don't understand. Why not fix the actual defines so that FIELD_GET() works correctly and no manual shifting is needed? In this example from BIT(1) to BIT(7). -- https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
