Hi Johannes,
On 2020-08-19 12:24, Johannes Berg wrote:
On Wed, 2020-08-19 at 12:15 +0530, Seevalamuthu Mariappan wrote:
AP-VLAN multicast/broadcast packets are expected to be encrypted
in software.
Err. Expected by whom?
Not an expectation exactly. As of now, AP-VLAN multicast/broadcast
packets are encrypted in mac80211 itself. So these packets needs to go
through 80211_xmit path. This change is just to redirect the other
packets (unicast) to 802.3 xmit path if hw encap is enabled on AP
interface.
Those packets should follow 802.11 xmit path.
You should explain why ...
-void __ieee80211_subif_start_xmit(struct sk_buff *skb,
- struct net_device *dev,
- u32 info_flags,
- u32 ctrl_flags,
- u64 *cookie)
There's no way I can review this if you move the whole function while
making a small change to it ...
Will split into two patches, one having function movement and another
patch having the actual change.
johannes
Thanks,
Seevalamuthu M
