trix@xxxxxxxxxx wrote:
> From: Tom Rix <trix@xxxxxxxxxx>
>
> Clang static analysis reports this error
>
> brcmfmac/core.c:490:4: warning: Dereference of null pointer
> (*ifp)->ndev->stats.rx_errors++;
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> In this block of code
>
> if (ret || !(*ifp) || !(*ifp)->ndev) {
> if (ret != -ENODATA && *ifp)
> (*ifp)->ndev->stats.rx_errors++;
> brcmu_pkt_buf_free_skb(skb);
> return -ENODATA;
> }
>
> (*ifp)->ndev being NULL is caught as an error
> But then it is used to report the error.
>
> So add a check before using it.
>
> Fixes: 91b632803ee4 ("brcmfmac: Use net_device_stats from struct net_device")
> Signed-off-by: Tom Rix <trix@xxxxxxxxxx>
Patch applied to wireless-drivers-next.git, thanks.
9c9f015bc9f8 brcmfmac: check ndev pointer
--
https://patchwork.kernel.org/patch/11696567/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
