Lee Jones <lee.jones@xxxxxxxxxx> writes: > - Ensure spaces appear after {for, if, while, etc} > - Ensure spaces to not appear after '(' > - Ensure spaces to not appear before ')' > - Ensure spaces appear between ')' and '{' > - Ensure spaces appear after ',' > - Ensure spaces do not appear before ',' > - Ensure spaces appear either side of '=' > - Ensure '{'s which open functions are on a new line > - Remove trailing whitespace > > There are still a whole host of issues with this file, but this > patch certainly breaks the back of them. > > Cc: Kalle Valo <kvalo@xxxxxxxxxxxxxx> > Cc: "David S. Miller" <davem@xxxxxxxxxxxxx> > Cc: Jakub Kicinski <kuba@xxxxxxxxxx> > Cc: Benjamin Reed <breed@xxxxxxxxxxxxxxxxxxxxx> > Cc: Javier Achirica <achirica@xxxxxxxxxxxxxxxxxxxxx> > Cc: Jean Tourrilhes <jt@xxxxxxxxxx> > Cc: Fabrice Bellet <fabrice@xxxxxxxxxxx> > Cc: linux-wireless@xxxxxxxxxxxxxxx > Cc: netdev@xxxxxxxxxxxxxxx > Signed-off-by: Lee Jones <lee.jones@xxxxxxxxxx> > --- > drivers/net/wireless/cisco/airo.c | 897 ++++++++++++++++-------------- > 1 file changed, 467 insertions(+), 430 deletions(-) This is a driver for ancient hardware, I'm not sure if it's worth trying to fix any style issues. Is anyone even using it? Should we instead just remove the driver? -- https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches