On Mon, 2020-08-03 at 11:11 +0200, Johannes Berg wrote:
> On Mon, 2020-08-03 at 10:51 +0200, John Crispin wrote:
> > From: Miles Hu <milehu@xxxxxxxxxxxxxx>
> >
> > This patch adds the nl80211 structs, definitions, policies and parsing
> > code required to pass fixed HE rate, gi and ltf settings.
>
> Would be nice to capitalize acronyms like 'GI' and 'LTF' in free text
> ... :)
>
> > [NL80211_TXRATE_VHT] = NLA_POLICY_EXACT_LEN_WARN(sizeof(struct nl80211_txrate_vht)),
> > [NL80211_TXRATE_GI] = { .type = NLA_U8 },
> > + [NL80211_TXRATE_HE] = NLA_POLICY_EXACT_LEN_WARN(sizeof(struct nl80211_txrate_he)),
>
> _WARN is for backward compatibility, don't use it for new stuff.
>
>
> But fixed those and applied.
I take that back, it causes tests that hit the set rate code to crash.
johannes
