On Thu, 2020-07-30 at 15:08 -0700, Aloka Dixit wrote: > Min and max intervals are used to decide if a FILS discovery frame > should be sent at all when respective timers expires. > Depending on how close that time is to the next beacons, the device may > just send the beacon instead. Right, OK. > In lower bands, for non-offloaded case, FW will send events asking for > the frame until it gets one. Aha. > Whether that should go all the way to hostapd or should the driver > itself handle it remains to be seen. I don't see why it should go up - the driver can have the template and answer that? I mean, we already push the template down. > My current focus is only 6GHz, but didn't want to restrict kernel > implementation so moved 6GHz related checks to the driver instead. It might still make sense to have a bitmap of where FILS discovery is supported, if it's different for different bands? Unless of course you think that a given device will always support FILS discovery on all bands, you just haven't implemented it yet for all bands - but will complete it before really enabling it in the driver? > All in all, making the template mandatory will be safer so that the > driver will always have one if required. Agree. Thanks! johannes
