On 2020-07-30 14:22, Johannes Berg wrote:
On Thu, 2020-07-30 at 14:17 -0700, Aloka Dixit wrote:
> OTOH, if it's with headers, how could it be optional? In fact, either
> way, how is it optional?
>
Template has management frame headers as well. Will change the wording
accordingly.
OK.
I made the template optional because FILS discovery may or may not be
offloaded to FW.
But how would anyone know? Try without it, and then try again if that
fails? Would it fail? I mean, you also said it was required at least
for
6 GHz, so wouldn't userspace be better off always giving it - and then
we should probably make it mandatory so it doesn't fall into the trap?
If the template is not provided, FW keeps sending event to get it.
But as my ath11k driver code is limited to 6GHz, it already throws error
if template not provided.
Yes, in general it will be better to make it mandatory, I will do it in
next version.
However - and here that's my ignorance speaking - can it really be
offloaded? I mean, is everything in there completely determined by the
beacon already, and so you have no choice in how to build it? Or how
does that work?
Yes, the frame parameters are fixed except for the timestamp which FW is
expected to fill.
Yeah, I looked through existing examples for NLA_BINARY, those provide
only the higher bound for length.
Yeah, no way to do anything else right now. But you should have a lower
bound in the code, I think.
Okay.
But I can modify it to range once that is added.
Later maybe :)
johannes
