On Mon, 2020-07-06 at 13:52 +0200, John Crispin wrote: > > @@ -3761,6 +3765,16 @@ static int nl80211_new_interface(struct sk_buff *skb, struct genl_info *info) > if (err < 0) > return err; > > + if (info->attrs[NL80211_ATTR_MULTI_BSSID_MODE]) > + params.multi_bssid_mode = > + nla_get_u8(info->attrs[NL80211_ATTR_MULTI_BSSID_MODE]); [...] Oh .. missed this completely until I got to the iw patch :) Why are you adding this in *new interface? IMHO it would be more applicable to "start_ap"? I don't see a reason why an interface couldn't change the role here regarding multi-BSSID while it's down? That might also address some of the whole "cfg80211" vs. "mac80211" thing I raised previously, since now cfg80211 would have a lot more knowledge about things if the interface is already operating, i.e. it could track and validate more of this? johannes
