On Mon, 2020-07-27 at 01:27 -0700, Joe Perches wrote: > On Mon, 2020-07-27 at 06:07 +0000, Pkshih wrote: > > On Sat, 2020-07-25 at 12:55 -0700, Joe Perches wrote: > > > Make these statements a little simpler. > [] > > > diff --git a/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c > [] > > > @@ -874,11 +874,10 @@ static void halbtc_display_wifi_status(struct > > > btc_coexist *btcoexist, > > > seq_printf(m, "\n %-35s = %s / %s/ %s/ AP=%d ", > > > "Wifi freq/ bw/ traffic", > > > gl_btc_wifi_freq_string[wifi_freq], > > > - ((wifi_under_b_mode) ? "11b" : > > > - gl_btc_wifi_bw_string[wifi_bw]), > > > - ((!wifi_busy) ? "idle" : ((BTC_WIFI_TRAFFIC_TX == > > > - wifi_traffic_dir) ? > "uplink" : > > > - "downlink")), > > > + wifi_under_b_mode ? "11b" : > gl_btc_wifi_bw_string[wifi_bw], > > > + (!wifi_busy ? "idle" : > > > + wifi_traffic_dir == BTC_WIFI_TRAFFIC_TX ? "uplink" : > > > + "downlink"), > > > > I think this would be better > > > > + !wifi_busy ? "idle" : > > + (wifi_traffic_dir == BTC_WIFI_TRAFFIC_TX ? "uplink" : > > + "downlink"), > > It seems most repeated test1 ? : test2 ? : test3 ?: > uses do not have the style you suggest in the kernel. > Your change is (test1 ? : test2 ? :) So, I think you would like to have parenthesis intentionally. If so, test1 ? : (test2 ? :) would be better. If not, test1 ? : test2 ? : may be what you want (without any parenthesis).
