On Sun, 2020-07-26 at 10:22 +0300, Kalle Valo wrote: > Sedat Dilek <sedat.dilek@xxxxxxxxx> writes: > > > Hi, > > > > I am seeing this failed/error message for a long time: > > > > [Sat Jul 25 13:03:28 2020] iwlwifi 0000:01:00.0: Direct firmware load > > for iwl-debug-yoyo.bin failed with error -2 > > > > So, I started to look for the file "iwl-debug-yoyo.bin" in [1], but failed. > > AFAICS this is a file for debugging purposes? > > > > Why do I see such a message as an end-user w/o iwlwifi-debugging enabled? > > For some end-users I can imagine this looks scary and they will look > > into their cupboards and below their beds but will not find any > > monsters. > > > > I found a rename from an ini file to bin here: > > commit 8d9e982bf9bf ("iwlwifi: dbg_ini: rename external debug > > configuration file") > > > > Is "iwl-debug-yoyo.bin" a binary or as before an ini (text) file I > > have to configure somehow. > > > > Does this need to be guarded by some "ifdef CONFIG_IWLWIFI_DEBUG" in > > "drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c"? > > > > Or does drivers/net/wireless/intel/iwlwifi/Makefile needs some tuning > > - as said I have no iwlwifi debugging enabled via Kconfig? > > ... > > iwlwifi-objs += iwl-dbg-tlv.o > > > > Please enlighten me/us? > > > > Thanks. > > > > Regards, > > - Sedat - > > > > [1] https://git.kernel.org/pub/scm/linux/kernel/git/iwlwifi/linux-firmware.git/ > > [2] https://git.kernel.org/linus/e8d9e982bf9bf0e6f99099f1f09a37563b2b95b5 > > > > > From my dmesg-output: > > > > [Sa Jul 25 13:03:28 2020] iwlwifi 0000:01:00.0: can't disable ASPM; OS > > doesn't have ASPM control > > [Sa Jul 25 13:03:28 2020] iwlwifi 0000:01:00.0: loaded firmware > > version 18.168.6.1 6000g2b-6.ucode op_mode iwldvm > > [Sa Jul 25 13:03:28 2020] iwlwifi 0000:01:00.0: Direct firmware load > > for iwl-debug-yoyo.bin failed with error -2 > > There's an RFC patch about this: > > https://patchwork.kernel.org/patch/11625759/ > > I think that should be applied. Intel folks, should I take that directly > to wireless-drivers-next? As I wrote in the other thread, yes, please. Go ahead and merge it. -- Cheers, Luca.