Search Linux Wireless

Re: [PATCH] ath11k: Fix memory leak in ath11k_qmi_init_service()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Wang Yufen <wangyufen@xxxxxxxxxx>, brcm80211-dev-list@xxxxxxxxxxx, linux-wireless@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxxxxxx
Subject: Re: [PATCH] ath11k: Fix memory leak in ath11k_qmi_init_service()
From: Markus Elfring <Markus.Elfring@xxxxxx>
Date: Mon, 20 Jul 2020 13:07:53 +0200
Cc: kernel-janitors@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, "David S. Miller" <davem@xxxxxxxxxxxxx>, Franky Lin <franky.lin@xxxxxxxxxxxx>, Jakub Kicinski <kuba@xxxxxxxxxx>, Kalle Valo <kvalo@xxxxxxxxxxxxxx>, Wright Feng <wright.feng@xxxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0

> When qmi_add_lookup fail, we should destroy the workqueue

Can the following wording variant be nicer for the change description?

   Destroy the work queue object in an if branch
   after a call of the function “qmi_add_lookup” failed.

Regards,
Markus

Prev by Date: Re: [PATCH] wilc1000: Move wilc1000 SDIO ID's from driver source to common header file
Next by Date: Re: [PATCH 1/4] wcn36xx: Fix multiple AMPDU sessions support
Previous by thread: [PATCH net-next] ath11k: Fix possible memleak in ath11k_qmi_init_service
Next by thread: [PATCH] cfg80211: allow vendor dumpit to terminate by returning 0
Index(es):
- Date
- Thread

[Index of Archives] [Linux Host AP] [ATH6KL] [Linux Wireless Personal Area Network] [Linux Bluetooth] [Wireless Regulations] [Linux Netdev] [Kernel Newbies] [Linux Kernel] [IDE] [Git] [Netfilter] [Bugtraq] [Yosemite Hiking] [MIPS Linux] [ARM Linux] [Linux RAID]

Powered by Linux