On Thu, 2020-07-16 at 21:01 -0500, Larry Finger wrote: > The macro name RT_TRACE makes it seem that it is used for tracing, when > is actually used for debugging. Change the name to RT_DEBUG. > > In the initial step, RT_TRACE must be kept to allow building. It will > be removed at the end of the patch series. Likely this patch could be broken out so that the addition of RT_DEBUG is patch 1 and the remainder of this patch is patch 2. And I'd suggest not using RT_DEBUG as the macro but use rtl_dbg instead. Lastly, the _rtl_dbg_trace function should probably be renamed _rtl_dbg. Other than that, I think this entire series is sensible, thanks.
