Fixed
On 7/13/20 3:44 PM, Kalle Valo wrote:
+ linux-wireless
Saheed Olayemi Bolarinwa <refactormyself@xxxxxxxxx> writes:
From: Bolarinwa Olayemi Saheed <refactormyself@xxxxxxxxx>
Cc: bjorn@xxxxxxxxxxx,
skhan@xxxxxxxxxxxxxxxxxxx,
linux-pci@xxxxxxxxxxxxxxx,
linux-kernel-mentees@xxxxxxxxxxxxxxxxxxxxxxxxx,
linux-kernel@xxxxxxxxxxxxxxx,
Stanislaw Gruszka <stf_xl@xxxxx>,
linux-wireless@xxxxxxxxxxxxxxx,
netdev@xxxxxxxxxxxxxxx
On failure pcie_capability_read_dword() sets it's last parameter, val
to 0. However, with Patch 14/14, it is possible that val is set to ~0 on
failure. This would introduce a bug because (x & x) == (~0 & x).
This bug can be avoided without changing the function's behaviour if the
return value of pcie_capability_read_dword is checked to confirm success.
Check the return value of pcie_capability_read_dword() to ensure success.
Suggested-by: Bjorn Helgaas <bjorn@xxxxxxxxxxx>
Signed-off-by: Bolarinwa Olayemi Saheed <refactormyself@xxxxxxxxx>
Please check your setup, linux-wireless was not in Cc field.
Thank you for letting me know. I have fixed it and resent to the missing
addresses.
