> -----Original Message-----
> From: Doug Anderson <dianders@xxxxxxxxxxxx>
> Sent: Saturday, June 27, 2020 3:22 AM
> To: Rakesh Pillai <pillair@xxxxxxxxxxxxxx>; Kalle Valo
> <kvalo@xxxxxxxxxxxxxx>
> Cc: ath10k@xxxxxxxxxxxxxxxxxxx; open list:OPEN FIRMWARE AND FLATTENED
> DEVICE TREE BINDINGS <devicetree@xxxxxxxxxxxxxxx>; linux-wireless <linux-
> wireless@xxxxxxxxxxxxxxx>; LKML <linux-kernel@xxxxxxxxxxxxxxx>
> Subject: Re: [PATCH 2/2] ath10k: Add support for chain1 regulator supply
> voting
>
> Hi,
>
> On Fri, Jun 26, 2020 at 11:02 AM Rakesh Pillai <pillair@xxxxxxxxxxxxxx> wrote:
> >
> > Add support to vote for chain-1 voltage regulator
> > in WCN3990.
> >
> > Tested-on: WCN3990 hw1.0 SNOC WLAN.HL.3.1-01040-QCAHLSWMTPLZ-1
> >
> > Signed-off-by: Rakesh Pillai <pillair@xxxxxxxxxxxxxx>
> > ---
> > drivers/net/wireless/ath/ath10k/snoc.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/net/wireless/ath/ath10k/snoc.c
> b/drivers/net/wireless/ath/ath10k/snoc.c
> > index 645ed5f..407a074 100644
> > --- a/drivers/net/wireless/ath/ath10k/snoc.c
> > +++ b/drivers/net/wireless/ath/ath10k/snoc.c
> > @@ -45,6 +45,7 @@ static const char * const ath10k_regulators[] = {
> > "vdd-1.8-xo",
> > "vdd-1.3-rfa",
> > "vdd-3.3-ch0",
> > + "vdd-3.3-ch1",
>
> Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx>
>
> ...with the slight nit that ${SUBJECT} and description should probably
> call it "chan1" and not "chain1". Presumably the maintainer can fix
> when applying.
>
> -Doug
Hi Doug,
It has to be chain1 only, not chan1.
This is the power supply rail for the wlan-chain1
