On 2020-06-28 19:09, Pkshih wrote:
On Sun, 2020-06-28 at 03:17 -0700, Joe Perches wrote:
Use 'rtlwifi:' as subject title prefix is enough, likes
rtlwifi: Use const in swing_table declarations
We disagree.
I like knowing what content is changed via patch subject lines
as there are 3 rtlwifi drivers being changed by this one patch.
But your choice, you can change it if you choose.
Reduce data usage about 1KB by using const.
[]
Please remove below type casting:
@@ -1872,10 +1872,10 @@ static void
rtl8821ae_get_delta_swing_table(struct
ieee80211_hw *hw,
*up_b = rtl8821ae_delta_swing_table_idx_5gb_p[2];
*down_b = rtl8821ae_delta_swing_table_idx_5gb_n[2];
} else {
- *up_a = (u8 *)rtl8818e_delta_swing_table_idx_24gb_p;
- *down_a = (u8 *)rtl8818e_delta_swing_table_idx_24gb_n;
- *up_b = (u8 *)rtl8818e_delta_swing_table_idx_24gb_p;
- *down_b = (u8 *)rtl8818e_delta_swing_table_idx_24gb_n;
+ *up_a = rtl8818e_delta_swing_table_idx_24gb_p;
+ *down_a = rtl8818e_delta_swing_table_idx_24gb_n;
+ *up_b = rtl8818e_delta_swing_table_idx_24gb_p;
+ *down_b = rtl8818e_delta_swing_table_idx_24gb_n;
The compiler is quiet about this so I believe this to be
an unrelated change and whitespace correction.
Of course you could modify it if you choose.
btw: There's an unnecessary return at the 2nd instance
of this cast removal too.
cheers, Joe
