Hi, I love your patch! Perhaps something to improve: [auto build test WARNING on wireless-drivers-next/master] [also build test WARNING on wireless-drivers/master sparc-next/master v5.8-rc2 next-20200625] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/matthias-bgg-kernel-org/brcmfmac-Transform-compatible-string-for-FW-loading/20200626-001324 base: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git master config: riscv-allyesconfig (attached as .config) compiler: riscv64-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=riscv If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@xxxxxxxxx> All warnings (new ones prefixed by >>): drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c: In function 'brcmf_of_probe': >> drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c:35:3: warning: 'strncpy' output truncated before terminating nul copying as many bytes from a string as its length [-Wstringop-truncation] 35 | strncpy(board_type, tmp, strlen(tmp)); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ vim +/strncpy +35 drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c 14 15 void brcmf_of_probe(struct device *dev, enum brcmf_bus_type bus_type, 16 struct brcmf_mp_device *settings) 17 { 18 struct brcmfmac_sdio_pd *sdio = &settings->bus.sdio; 19 struct device_node *root, *np = dev->of_node; 20 int irq; 21 u32 irqf; 22 u32 val; 23 24 /* Set board-type to the first string of the machine compatible prop */ 25 root = of_find_node_by_path("/"); 26 if (root) { 27 int i; 28 char *board_type; 29 const char *tmp; 30 31 of_property_read_string_index(root, "compatible", 0, &tmp); 32 33 /* get rid of '/' in the compatible string to be able to find the FW */ 34 board_type = devm_kzalloc(dev, strlen(tmp), GFP_KERNEL); > 35 strncpy(board_type, tmp, strlen(tmp)); --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx
Attachment:
.config.gz
Description: application/gzip
