> On Tue, 2020-06-23 at 21:10 +0300, Luca Coelho wrote: > > From: Emmanuel Grumbach <emmanuel.grumbach@xxxxxxxxx> > > > > When we suspend, we can't really remember our BSS table. > > Sure we can. We do today :-) > > Yes, I know why you want this for iwlwifi, but this commit message isn't > good. And if you had a good commit message, you'd know that it's actually > only needed for iwlwifi, not for basically anyone else. I agree the commit message isn't sufficient and was written quickly to get the bugfix in, I should have rewritten it before getting it published. > > And, in fact, it's not even needed for iwlwifi because if you had WoWLAN > then the firmware stays running and you don't need it. > > > Purge all the data. > > We age it already since commit cb3a8eec0e66. That should be sufficient for > most devices. > > And in fact, if it weren't, then this should have removed the ageing that's > now completely pointless :) > > > Export this function to allow driver to purge the BSS table in case > > they feel the need to. > > iwlwifi will need to do that. > > I think we should just have a patch to purge it, without the call in sysfs.c, and > do then iwlwifi can call it in the right places (when it resets the firmware.) I will rework this patch. I'll keep this function and call it from iwlwifi only. > > Note this won't even be _perfect_ because there are reasons (like being > connected) that mean the entry is not removed even when flushing, so that > should probably be documented. > > johannes
