> Lorenzo Bianconi <lorenzo.bianconi@xxxxxxxxxx> writes: > > >> Lorenzo Bianconi <lorenzo@xxxxxxxxxx> writes: > >> > >> > Fix the two following memory leaks in mt7663u_probe: > >> > 1- if device power-own times out, remove ieee80211 hw device. > >> > 2- if mt76u queues allocation fails, remove pending urbs. > >> > >> One logical change per patch, please. If you have to create a list of > >> changes in the commit log that's a good sign that you need to split the > >> patch :) > > > > both of them are memory leaks in the error path of the same routine (mt7663u_probe()). > > Do I need to split them even in this case? If so I am fine with it. > > Do I need to send a v3? > > Oh, I didn't notice that they were in the same function. So I guess this > sort of gray area and no need to send v3 because of this. ack, I will take into account for the next time, thanks :) Regards, Lorenzo > > -- > https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches >
Attachment:
signature.asc
Description: PGP signature