John Crispin <john@xxxxxxxxxxx> writes:
> Whenever the MAC detects a color collision or any of its associated station
> detects one the FW will send out an event. Add the code to parse and handle
> this event. and pass the data up to mac80211.
>
> The FW does not provide an offload future such as the one used for CSA. The
> CCA process is hence triggered via the beacon offload tx completion events
> sent out by the FW.
>
> Signed-off-by: John Crispin <john@xxxxxxxxxxx>
On what hardware and firmware did you test this? I'll add that to the
commit log.
> + if (ev->obss_color_bitmap & BIT(arvif->vif->bss_conf.he_bss_color.color)) {
> + /* FW sometime sends out stray events. Ignore them if our color is free */
> + ieeee80211_obss_color_collision_notify(arvif->vif, ev->obss_color_bitmap);
> +
> + ath11k_info(ab, "OBSS color collision detected vdev:%d, event:%d, bitmap:%08llx\n",
> + ev->vdev_id, ev->evt_type, ev->obss_color_bitmap);
> + }
Is this really something so important that we should print it to the
log? What should the user do after seeing this warning?
And warnings should be printed with ath11k_warn(), but maybe this should
be a debug message?
--
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
