Search Linux Wireless

Re: [PATCH v6] ath10k: provide survey info as accumulated data

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Kalle Valo <kvalo@xxxxxxxxxxxxxx> wrote:

> It is expected that the returned counters by .get_survey are monotonic
> increasing. But the data from ath10k gets reset to zero regularly. Channel
> active/busy time are then showing incorrect values (less than previous or
> sometimes zero) for the currently active channel during successive survey
> dump commands.
> 
> example:
> 
>   $ iw dev wlan0 survey dump
>   Survey data from wlan0
>   	frequency:                      5180 MHz [in use]
>   	channel active time:            54995 ms
>   	channel busy time:              432 ms
>   	channel receive time:           0 ms
>   	channel transmit time:          59 ms
>   ...
> 
>   $ iw dev wlan0 survey dump
>   Survey data from wlan0
>   	frequency:                      5180 MHz [in use]
>   	channel active time:            32592 ms
>   	channel busy time:              254 ms
>   	channel receive time:           0 ms
>   	channel transmit time:          0 ms
>   ...
> 
> The correct way to handle this is to use the non-clearing
> WMI_BSS_SURVEY_REQ_TYPE_READ wmi_bss_survey_req_type. The firmware will
> then accumulate the survey data and handle wrap arounds.
> 
> Tested-on: QCA9984 hw1.0 10.4-3.5.3-00057
> Tested-on: QCA988X hw2.0 10.2.4-1.0-00047
> Tested-on: QCA9888 hw2.0 10.4-3.9.0.2-00024
> Tested-on: QCA4019 hw1.0 10.4-3.6-00140
> 
> Fixes: fa7937e3d5c2 ("ath10k: update bss channel survey information")
> Signed-off-by: Venkateswara Naralasetty <vnaralas@xxxxxxxxxxxxxx>
> Tested-by: Markus Theil <markus.theil@xxxxxxxxxxxxx>
> Tested-by: John Deere <24601deerej@xxxxxxxxx>
> [sven@xxxxxxxxxxxxx: adjust commit message]
> Signed-off-by: Sven Eckelmann <sven@xxxxxxxxxxxxx>
> Signed-off-by: Kalle Valo <kvalo@xxxxxxxxxxxxxx>

Patch applied to ath-next branch of ath.git, thanks.

720e5c03e5cb ath10k: provide survey info as accumulated data

-- 
https://patchwork.kernel.org/patch/11605281/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches




[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Wireless Regulations]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux