On 2020-06-13 17:47, Aloka Dixit wrote:
On 2020-06-04 00:38, Arend Van Spriel wrote:
On 6/2/2020 3:38 AM, Aloka Dixit wrote:
This patchset adds support for FILS discovery transmission as per
IEEE Std 802.11ai-2016.
This is the next version in the series given below:
FILS discovery and bcast probe resp support.
Unsolicited broadcast probe response support is now split into
a separate patchset.
Hi Aloka,
What is your motivation for the split? As you stated earlier FILS
discovery and unsollicited probe responses are mutual exclusive as it
only eats up airtime to do both. I tend to agree to that earlier
statement so I would like to see some arguments for doing the split.
Hi Arend,
Two reasons to split the patches:
(1) Unsolicited broadcast probe response is specific to 6GHz whereas
FILS discovery is applicable in all bands. I haven't added a check for
6GHz for the former in nl80211 and mac80211 code because I expect the
application and driver implementations to add it.
(2) IEEE P802.11ax/D6.0 mentions that a device "may" skip FILS
discovery transmission and instead schedule unsolicited broadcast
probe response (if enabled) in 6GHz, but it is not mandatory.
So it made sense to have two separate attributes and let the driver
and/or FW implementation decide if both can be active at the same
time. nl80211 and mac80211 shouldn't make that decision.
With separate attributes, having separate patches are easier to review.
The second point I added above is not entirely correct - if unsolicited
broadcast response is active then FILS discovery must be omitted, but if
it is not active, then also device may choose to send probe response
instead of FILS discovery.
But that decision should not be made at nl80211 or mac80211.
Regards,
Arend
Aloka Dixit (2):
nl80211: Add FILS discovery support
mac80211: Add FILS discovery transmission support
include/net/cfg80211.h | 25 ++++++++++++++++
include/net/mac80211.h | 31 ++++++++++++++++++++
include/uapi/linux/nl80211.h | 46 +++++++++++++++++++++++++++++
net/mac80211/cfg.c | 46 +++++++++++++++++++++++++++++
net/mac80211/ieee80211_i.h | 7 +++++
net/mac80211/tx.c | 25 ++++++++++++++++
net/wireless/nl80211.c | 57
++++++++++++++++++++++++++++++++++++
7 files changed, 237 insertions(+)
