On Thu, 2019-11-21 at 15:48 +0800, Wang Xuerui wrote: > Previously the non-ACPI stub of iwl_mvm_ppag_init unconditionally > returned -ENOENT, that in turn blocked flow of iwl_mvm_up. > > Take the precedent of iwl_mvm_sar_geo_init, make iwl_mvm_ppag_init no-op > on non-ACPI configs. > > Fixes: 6ce1e5c0c207 ("iwlwifi: support per-platform antenna gain") > Cc: Gil Adam <gil.adam@xxxxxxxxx> > Cc: Luca Coelho <luciano.coelho@xxxxxxxxx> > Signed-off-by: Wang Xuerui <git@xxxxxxxxxx> > --- > drivers/net/wireless/intel/iwlwifi/mvm/fw.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/fw.c b/drivers/net/wireless/intel/iwlwifi/mvm/fw.c > index d9eb2b286438..04ac47b7cae9 100644 > --- a/drivers/net/wireless/intel/iwlwifi/mvm/fw.c > +++ b/drivers/net/wireless/intel/iwlwifi/mvm/fw.c > @@ -1169,7 +1169,7 @@ int iwl_mvm_ppag_send_cmd(struct iwl_mvm *mvm) > > static int iwl_mvm_ppag_init(struct iwl_mvm *mvm) > { > - return -ENOENT; > + return 0; > } > #endif /* CONFIG_ACPI */ This was already fixed in another patch. Thanks anyway! -- Cheers, Luca.