On Wed, Sep 3, 2008 at 12:01 AM, John W. Linville <linville@xxxxxxxxxxxxx> wrote: > On Thu, Aug 28, 2008 at 05:25:07PM +0800, Zhu Yi wrote: >> From: Gregory Greenman <gregory.greenman@xxxxxxxxx> >> >> This patch calls apm stop on exit and suspend and sets STATUS_EXIT_PENDING >> accordingly. Without this patch hardware consumes power even after driver >> is removed or suspended. >> >> Signed-off-by: Gregory Greenman <gregory.greenman@xxxxxxxxx> >> Signed-off-by: Mohamed Abbas <mohamed.abbas@xxxxxxxxx> >> Signed-off-by: Tomas Winkler <tomas.winkler@xxxxxxxxx> >> Signed-off-by: Zhu Yi <yi.zhu@xxxxxxxxx> > > The two hunks of this patch seem like two different fixes, and the > changelog only matches the first hunk. When you resubmit this series > (which I presume you will be doing with better changelogs after > Marcel's commentary), please split this into two patches. > It's not so obvious form the reading the patch but these two hunks belongs together. Without the second hunk the exit flow is not correct and first hunk fix has no effect. Although I don't mind to split them providing it's easier to swallow. Thanks Tomas -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
