<yhchuang@xxxxxxxxxxx> wrote: > From: Chien-Hsun Liao <ben.liao@xxxxxxxxxxx> > > The CCK TX setting when switch channel will fix the CCK to > path A only, so if the antenna is configured to path B > (e.g. iw phy set antenna 0x2 0x3 "TX B/RX AB"), then the CCK > packets can never be delivered to the air if only path B is > connected with an antenna (it can possibly be transmitted > through path A, but as path B is configured, the expected > behavior is incorrect). > > This can also solve the racing issue of CCK TX setting between > driver and firmware. The CCK TX setting in driver should be > removed. Otherwise, the CCK TX setting would be wrong when the > racing occurs. > > Fixes: 297bcf8222f2 ("rtw88: add support for set/get antennas") > Signed-off-by: Chien-Hsun Liao <ben.liao@xxxxxxxxxxx> > Signed-off-by: Yan-Hsuan Chuang <yhchuang@xxxxxxxxxxx> Patch applied to wireless-drivers-next.git, thanks. 7967af8de39d rtw88: 8822c: remove CCK TX setting when switch channel -- https://patchwork.kernel.org/patch/11565095/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches