On 2020-05-29 06:31:23 [+0000], Tony Chuang wrote: > > > +static void rtw8821c_phy_calibration(struct rtw_dev *rtwdev) > > > +{ > > > + rtw8821c_do_iqk(rtwdev); > > > > Why this extra step? You could name it rtw8821c_phy_calibration_iqk(). > > > > This is hooked at rtw_chip_ops::phy_calibration(). For 8821C, only IQK is > required. So just keep the name consistent. Ah okay. > Yan-Hsuan Sebastian