Hi again :)
So ...
> @@ -4803,7 +4809,8 @@ static int ieee80211_prep_channel(struct ieee80211_sub_if_data *sdata,
> if (!sband->ht_cap.ht_supported) {
> ifmgd->flags |= IEEE80211_STA_DISABLE_HT;
> ifmgd->flags |= IEEE80211_STA_DISABLE_VHT;
> - ifmgd->flags |= IEEE80211_STA_DISABLE_HE;
> + if (sband->band != NL80211_BAND_6GHZ)
> + ifmgd->flags |= IEEE80211_STA_DISABLE_HE;
> }
>
> if (!sband->vht_cap.vht_supported)
> @@ -5493,7 +5500,8 @@ int ieee80211_mgd_assoc(struct ieee80211_sub_if_data *sdata,
> if (req->flags & ASSOC_REQ_DISABLE_HT) {
> ifmgd->flags |= IEEE80211_STA_DISABLE_HT;
> ifmgd->flags |= IEEE80211_STA_DISABLE_VHT;
> - ifmgd->flags |= IEEE80211_STA_DISABLE_HE;
> + if (sband->band != NL80211_BAND_6GHZ)
> + ifmgd->flags |= IEEE80211_STA_DISABLE_HE;
I had dropped these bits from the patch earlier, because they didn't
really seem to belong here.
Now that I look at them in more detail, and compare to what I had done
before, it seems that this isn't really suitable...
For example for better or worse, IEEE80211_STA_DISABLE_HT and
IEEE80211_STA_DISABLE_VHT are checked in various places, for example in
the CSA code.
I had instead done here
bool is_6ghz = cbss->channel->band == NL80211_BAND_6GHZ;
[...]
- if (!sband->ht_cap.ht_supported) {
+ if (!sband->ht_cap.ht_supported && !is_6ghz) {
and so on.
Technically, *of course* you're right in that HT/VHT are disabled on 6
GHz channels. In practice, we've clearly not disentangled that enough
yet, I think.
I'll post the patch as I had it, wrt. these flags, and then we can see
about cleaning it up?
johannes
