On 5/27/20 4:47 PM, Johannes Berg wrote: > On Wed, 2020-05-27 at 16:36 +0200, Markus Theil wrote: >> This patch adds the actual code for returning the tx status of control >> port frames sent over nl80211. >> >> NL80211_CMD_CONTROL_PORT_FRAME_TX_STATUS is a new command which is used >> when returning the tx status. Its availability can be queried by checking >> against NL80211_EXT_FEATURE_CONTROL_PORT_OVER_NL80211_TX_STATUS. >> >> The ctrl port tx status over nl80211 path re-uses some code from the path >> for advertising the tx status over socket control messages, when >> SKBTX_WIFI_STATUS is set. >> >> The tx status can be used in a similar fashion as the mgmt tx status >> already allows for. A cookie is included extended ack data of >> NL80211_CMD_CONTROL_PORT_FRAME, which can be matched against the cookie >> in NL80211_CMD_CONTROL_PORT_FRAME_TX_STATUS. The frame content is also >> included, as for example hostapd currently uses it to match request and >> reply. > Looks good on a cursory review, but you forgot to set the feature flag? Oh, I indeed forgot the flag. > johannes >
