On Tue, 2020-05-26 at 10:18 +0200, Arend Van Spriel wrote:
> On 5/26/2020 2:09 AM, Aloka Dixit wrote:
> > This patch adds new attribute, NL80211_ATTR_FD_BCASTPRESP_CFG
> > to configure FILS discovery and broadcast probe response in 6GHz
> > for in-band discovery.
> >
> > Only one of the two is active at a time to reduce broadcast
> > packets over the air.
> >
> > Maximum packet interval can be 20 TUs.
> > Packet interval set to 0 disables FILS discovery and broadcast
> > probe response transmission.
> >
> > Signed-off-by: Aloka Dixit <alokad@xxxxxxxxxxxxxx>
> > Reported-by: kbuild test robot <lkp@xxxxxxxxx>
>
> huh? what is reported. Oh, guess it is the reason for having v2. Don't
> think this tag is useful for that. Only useful if v1 would have been
> applied and this patch would fix that.
Yeah, that's a bit confusing. OTOH, they do like to be credited for the
fixes too ... Maybe that should then be "Co-developed-by" ;-)
I really don't know a good solution to this, but would probably drop the
tag(s).
> > @@ -974,6 +978,8 @@ struct cfg80211_beacon_data {
> > const u8 *probe_resp;
> > const u8 *lci;
> > const u8 *civicloc;
> > + const u8 *bcast_presp;
> > + const u8 *fils_disc;
>
> This is not really beacon data, now is it?
Well, neither is the probe_resp template :)
I guess we should rename this to ... cfg80211_beaconing_data? I dunno. I
mean, this thing is for beaconing and related things, and can be swapped
during runtime for a new beacon/config.
So that seems OK. However, Dan found an issue, so please respin.
johannes
