Search Linux Wireless

Re: [PATCH v4 5/5] nl80211: S1G band and channel definitions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Thomas,

This looks mostly good (and I've applied the other 4 patches with some
fixups), but ...

> @@ -911,6 +931,15 @@ bool cfg80211_chandef_usable(struct wiphy *wiphy,
>  	control_freq = chandef->chan->center_freq;
>  
>  	switch (chandef->width) {
> +	case NL80211_CHAN_WIDTH_1:
> +		width = 1;
> +		break;
> +	case NL80211_CHAN_WIDTH_2:
> +		width = 2;
> +		break;
> +	case NL80211_CHAN_WIDTH_4:
> +		width = 4;
> +		break;
>  	case NL80211_CHAN_WIDTH_5:

aren't you missing some bandwidths here? You'd fall through to a
WARN_ON(), which doesn't seem good?

johannes




[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Wireless Regulations]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux