On 05/19/2020 7:29, Arend Van Spriel wrote:
On 5/19/2020 1:09 PM, Chi-Hsien Lin wrote:
From: Double Lo <double.lo@xxxxxxxxxxx>
Increase dcmd maximum buffer size to match firmware configuration for
new chips.
From the description I was expecting BRCMF_DCMD_MAXLEN to be increased
but that is not the case. Please explain the need for the
ROUND_UP_MARGIN. Is it always needed or just on some platforms?
Thanks for the feedback.
ROUND_UP_MARGIN is the biggest SDIO block size possible and is used to
accomodate padding in brcmf_sdio_read_control(). This should be only
related to SDIO block size.
The comment should be updated to "Add the padding round up value in the
max control buffer size". Will update it in V2.
Regards,
Arend