On Sat, May 16, 2020 at 11:39:34AM +0100, Malcolm Priestley wrote: > Create room for vnt_tx_short_buf_head in sk_buff and vnt_tx_usb_header. > > The struct ieee80211_mgmt is not longer in the header and is at > the initial skb->data point. I feel like the SubmittingPatches guidelines on verb tenses and not saying "this patch" or "I" has got everyone so worried that it's like playing Taboo. Do you mean that the struct moved before or after we aply *this patch*? > > Signed-off-by: Malcolm Priestley <tvboxspy@xxxxxxxxx> I can't understand the point of this patch at all. Is it a fix or a clean up? If I had to guess from the subjec, I would say it's a performance improvement but I don't know. regards, dan carpenter