Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote: > Seven years ago we tried to fix a leak but actually introduced a double > free instead. It was an understandable mistake because the code was a > bit confusing and the free was done in the wrong place. The "skb" > pointer is freed in both _rtl_usb_tx_urb_setup() and _rtl_usb_transmit(). > The free belongs _rtl_usb_transmit() instead of _rtl_usb_tx_urb_setup() > and I've cleaned the code up a bit to hopefully make it more clear. > > Fixes: 36ef0b473fbf ("rtlwifi: usb: add missing freeing of skbuff") > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> Patch applied to wireless-drivers-next.git, thanks. beb12813bc75 rtlwifi: Fix a double free in _rtl_usb_tx_urb_setup() -- https://patchwork.kernel.org/patch/11545535/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches