On Tue, May 05, 2020 at 10:13:54PM +0100, Malcolm Priestley wrote:
> diff --git a/drivers/staging/vt6656/rxtx.c b/drivers/staging/vt6656/rxtx.c
> index 6724b213a723..48fe16c27d3f 100644
> --- a/drivers/staging/vt6656/rxtx.c
> +++ b/drivers/staging/vt6656/rxtx.c
> @@ -285,28 +285,18 @@ static __le16 vnt_get_rtscts_duration_le(struct vnt_usb_send_context *context,
> u8 dur_type, u8 pkt_type, u16 rate)
> {
> struct vnt_private *priv = context->priv;
> - u32 cts_time = 0, dur_time = 0;
> + u32 dur_time = 0;
> u32 frame_length = context->frame_len;
> u8 need_ack = context->need_ack;
> + struct ieee80211_tx_info *info = IEEE80211_SKB_CB(context->skb);
>
> switch (dur_type) {
> + /* fall through */
> case RTSDUR_BB:
> case RTSDUR_BA:
This fall through annotation shouldn't be necessary. It's not preceded
by a case statement. Also you don't need /* fall through */ for empty
case statements. In other words you only need it for stuff like this:
case FOO:
case BAR:
frob();
frob();
/* fall through */
case BAZ:
regards,
dan carpenter
