Search Linux Wireless

Re: [PATCH 1/4] ath11k: Add PCI client driver for QCA6390 chipset

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Kalle,

On 2020-05-11 23:29, Kalle Valo wrote:
Govind Singh <govinds@xxxxxxxxxxxxxx> writes:

QCA6390 is PCI based 11ax chipset, add
pci client driver for QCA6390 target.

Signed-off-by: Govind Singh <govinds@xxxxxxxxxxxxxx>

This patch had multiple problems, most important ones were:

* a break missing in ath11k_pci_probe()


My bad. Thanks for fixing same.

* it's not possible to have static variables in .h files, I fixed by
  moving the ring variables to core.c in a separate patch:

  https://patchwork.kernel.org/patch/11541355/

* this patch didn't link (at least when compiling as modules), I fixed
  those by adding missing EXPORT_SYMBOL() macros


Looks, this is required after moving the ring mask from ahb to core.

Please double check my changes:

https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=pending&id=44a28b572070f578914367dc2469cef48ece13f4

Looks good to me.

BR,
Govind



[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Wireless Regulations]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux